Bug #52098 Own PDOStatement implementation ignore __call() #1538
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It's TSRMLS_CC when you call it, not TSRMLS_DC. |
|
Thanks, I think I would not catch that if I didn't search for it. Will remember it in the future though :) |
|
Tested with:
|
kalaspuffar
changed the title
| PDO_DBH_DRIVER_METHOD_KIND_STMT TSRMLS_CC) | ||
| || !stmt->dbh->cls_methods[PDO_DBH_DRIVER_METHOD_KIND_STMT]) { | ||
|
|
||
| #if PHP_API_VERSION >= 20041225 |
There was a problem hiding this comment.
Should be a macro here, nobody remembers which version 20041225 is. Same for other instances.
There was a problem hiding this comment.
Also, because 5.5 is 20121113 and this is the smallest supported PHP version, these checks are not needed there.
There was a problem hiding this comment.
Well this #if is found in the function call, so to be sure that the parameter required for my feature is available I thought they where required. But as you say they seem depreciated. I could remove them from the function declaration and call.
kalaspuffar
force-pushed
the
bug_52098
branch
from
28f4992 to
a124c81
Compare
kalaspuffar
force-pushed
the
bug_52098
branch
from
a124c81 to
84c153f
Compare
kalaspuffar
force-pushed
the
bug_52098
branch
from
84c153f to
cd3f68a
Compare
… of classes aswell.
|
merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tried to solve bug #52098 by adding a fallback so the get_method handler of the class also runs the standard get_method handler and returns the result of this call when a database function could not be found.