Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug #52098 for PHP7 #1539

Closed
wants to merge 9,949 commits into from
Closed

Bug #52098 for PHP7 #1539

wants to merge 9,949 commits into from

Conversation

@kalaspuffar
Copy link

kalaspuffar commented Sep 26, 2015

Tried to solve bug #52098 by adding a fallback so the get_method handler of the class also runs the standard get_method handler and returns the result of this call when a database function could not be found.

@staabm

This comment has been minimized.

Copy link
Contributor

staabm commented on TSRM/tsrm_win32.c in 0e843a4 Sep 22, 2015

Is this line intenionally duplicated?

This comment has been minimized.

Copy link
Contributor Author

weltling replied Sep 22, 2015

Of course not :) Just fixed it, thanks for the check.

weltling and others added 21 commits Sep 22, 2015
…ge replaced by zval_dtor_ptr().
and also keep the indices of func_get_args(). since they are similar
issue of #70574, thus reuse its test script.
* PHP-5.6:
  add missing header
  silence mkdir to fix fails after unclean test run
@smalyshev

This comment has been minimized.

Copy link
Contributor

smalyshev commented Oct 19, 2015

Could you please rebase the patch? Right now it seems to be unmergeable and contains broken pieces.

Tyrael and others added 11 commits Jun 9, 2015
Assert that a live-range does not start, while one for the same
variable is already active.

To satisfy this constraint, explicitly exclude writes from JMP_SET
and COALESCE. They were previously also handled correctly, because
their result variable was only killed after the second write to it
after the false branch. This just makes it more explicit.
@kalaspuffar kalaspuffar deleted the kalaspuffar:bug_52098_php7 branch Oct 19, 2015
weltling and others added 14 commits Jul 10, 2015
… a part of the fix serious refactoring was done. op_array->brk_cont_array was removed, and replaced with more general and speed efficient op_array->T_liveliness. ZEND_GOTO opcode is always replaced by ZEND_JMP at compile time). (Bob, Dmitry, Laruence)"

This reverts commit 5ee8413.
… into bug_52098_php7

* 'bug_52098_php7' of https://github.com/kalaspuffar/php-src: (40 commits)
  Changes to pass all tests
  fix NEWS
  fix test
  bump versions
  Added fallback for get_method so we run the standard get_method and trigger overloaded methods
  fix regressio introduce in 22e23e7
  bump release version
  sync NEWS
  bump version
  update NEWS
  Fixed bug #70293 (Crash with specific assertions and zend.assertions=-1)
  Fixed memleak in Zend/tests/bug39297
  add NEWS entry
  Fixed bug #70288 (Apache crash related to ZEND_SEND_REF)
  sync NEWS
  bump versions
  sync NEWS
  sync NEWS
  set versions
  fix merge mistake
  ...
@kalaspuffar kalaspuffar restored the kalaspuffar:bug_52098_php7 branch Oct 19, 2015
@weltling

This comment has been minimized.

Copy link
Contributor Author

weltling commented on 4224907 Oct 23, 2015

yeah, snprintf will include \0, so lets not lose that one byte :) I'll push a fix soonish.

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.