Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug #64172 errorInfo is not properly cleaned up #1540

Closed
wants to merge 13 commits into from

Conversation

2 participants
@kalaspuffar
Copy link

commented Sep 26, 2015

Added a check to see if the error code is PDO_ERR_NONE then we don't ask for more error information.

  • Check if the SQLSTATE error code is equal to PDO_ERR_NONE before we ask the driver. And if no error is reported skip the extra call to the driver.
  • Added a test to check that errorInfo is not filled with the old statement error message.
  • Changed pdo_mysql/rests/pdo_mysql_stmt_errorinfo.phpt so It checks for NULL values when SQLSTATE error code is PDO_ERR_NONE so we follow manual page for PDO::errorInfo()

@kalaspuffar kalaspuffar changed the title Bug 64172 Bug #64172 Sep 26, 2015

@smalyshev smalyshev added the Bugfix label Sep 28, 2015

@kalaspuffar

This comment has been minimized.

Copy link
Author

commented Oct 5, 2015

Tested with:

DSN sqlite - sqlite memory database
DSN mysql - mysql database locally
DSN pgsql - postgresql database locally
DSN odbc - db2 database locally
DSN firebird - firebird database locally
DSN oci - oracle database locally
DSN dblib - mssql database Amazon EC2

@kalaspuffar kalaspuffar changed the title Bug #64172 Bug #64172 errorInfo is not properly cleaned up Oct 9, 2015

@smalyshev

This comment has been minimized.

Copy link
Contributor

commented Oct 19, 2015

merged

@smalyshev smalyshev closed this Oct 19, 2015

@kalaspuffar kalaspuffar deleted the kalaspuffar:bug_64172 branch Oct 19, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.