Skip to content

Conversation

kalaspuffar
Copy link

Added a check to see if the error code is PDO_ERR_NONE then we don't ask for more error information.

  • Check if the SQLSTATE error code is equal to PDO_ERR_NONE before we ask the driver. And if no error is reported skip the extra call to the driver.
  • Added a test to check that errorInfo is not filled with the old statement error message.
  • Changed pdo_mysql/rests/pdo_mysql_stmt_errorinfo.phpt so It checks for NULL values when SQLSTATE error code is PDO_ERR_NONE so we follow manual page for PDO::errorInfo()

@kalaspuffar kalaspuffar changed the title Bug 64172 for PHP7 Bug #64172 for PHP7 Sep 26, 2015
@smalyshev smalyshev added the Bug label Sep 28, 2015
@kalaspuffar
Copy link
Author

Tested with:

DSN sqlite - sqlite memory database
DSN mysql - mysql database locally
DSN pgsql - postgresql database locally
DSN odbc - db2 database locally
DSN firebird - firebird database locally
DSN oci - oracle database locally
DSN dblib - mssql database Amazon EC2

* upstream/PHP-7.0: (70 commits)
  Allow random $this on non-internal Closures again As it turns out, there is actually no reason to prevent this, it even was a bigger BC break than expected...
  Merge branch 'array_keys_strict_refs' of https://github.com/tony2001/php-src
  Improve 517b553 (scope rebinding on method Closures) Now it is completely impossible to rebind a scoped method Closure (only the kind you get from ReflectionMethod::getClosure()) to a foreign scope Adding a lot of tests to ensure this... Also, properly return NULL in case the Closure could not be created instead of some crippled unbound Closure
  improve error message
  fix incrementing on 32-bit
  fix coverage report for datelib
  Fixed bug #70632 (Third one of segfault in gc_remove_from_buffer)
  Fixed the third one of (segfault in gc_remove_from_buffer())
  Fixed bug #70631 (Another Segfault in gc_remove_from_buffer())
  Do not edit the zval cause it might be  in shared memory
  Fixed bug #70601 (Segfault in gc_remove_from_buffer())
  Fixed bug #70630 (Closure::call/bind() crash with ReflectionFunction->getClosure()) This additionally removes support for binding to an unknown (not in parent hierarchy) scope. Removing support for cross-scope is necessary for certain compile-time assumptions (like class constants) to prevent unexpected results
  remove useless checks
  fix win10 support
  Fixed bug #70625
  Updated to version 2015.7 (2015g)
  Updated to version 2015.7 (2015g)
  PHP7 is not affected
  Fixed bug #70619 (DateTimeImmutable segfault)
  Fix parse errors in -rr mode
  ...
@smalyshev
Copy link
Contributor

merged

@smalyshev smalyshev closed this Oct 19, 2015
@kalaspuffar kalaspuffar deleted the bug_64172_php7 branch October 19, 2015 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants