Autotools: Fix PHP_EMBED_TYPE variable substitution #15414
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a follow-up of f6dcca0 as Autoconf always seems to do a variable substitution, even when called conditionally. When passing argument other than shared or static to --enable-embed=ARGUMENT this now puts an empty string inside generated php-config script.
|
I'm merging this so I have this adjusted for the possible pkg-config changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up of f6dcca0 as Autoconf always seems to do a variable substitution, even when called conditionally. When passing argument other than shared or static to --enable-embed=ARGUMENT this now puts an empty string inside generated php-config script.