Skip to content

Conversation

petk
Copy link
Member

@petk petk commented Aug 24, 2024

When configuring with tidy library installed in non-standard paths, the library adding macro must be done before the PHP_CHECK_LIBRARY to be able to detect it. This fixes these edge cases. For example:

./configure --with-tidy=/path/to/custom-tidy-installation

@petk
Copy link
Member Author

petk commented Aug 24, 2024

FreeBSD still needs some adjustments here though for that tidy5 library name...

When configuring with tidy library installed in non-standard paths, the
library adding macro must be done before the PHP_CHECK_LIBRARY to be
able to detect it. This fixes these edge cases. For example:

    ./configure --with-tidy=/path/to/custom-tidy-installation
@petk petk force-pushed the patch-tidy-fixes branch from 1d2aca2 to ee15cee Compare August 25, 2024 18:00
@petk petk marked this pull request as ready for review August 25, 2024 18:00
@petk
Copy link
Member Author

petk commented Aug 25, 2024

Checks fixed by adding the -L$TIDY_DIR arguments to library checks instead of the initial fix meant in the PR.

Copy link
Member

@devnexen devnexen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mstm

@petk petk merged commit fef55bc into php:master Aug 26, 2024
9 of 10 checks passed
@petk petk deleted the patch-tidy-fixes branch August 26, 2024 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants