Skip to content

Fix ZEND_EXT_API wrt accessibility of OPcache symbols on Windows #15592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Fix ZEND_EXT_API wrt accessibility of OPcache symbols on Windows #15592

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion ext/opcache/ZendAccelerator.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,11 @@

#ifndef ZEND_EXT_API
# ifdef ZEND_WIN32
# define ZEND_EXT_API __declspec(dllexport)
# ifdef ZEND_EXT_EXPORTS
# define ZEND_EXT_API __declspec(dllexport)
# else
# define ZEND_EXT_API __declspec(dllimport)
# endif
# elif defined(__GNUC__) && __GNUC__ >= 4
# define ZEND_EXT_API __attribute__ ((visibility("default")))
# else
Expand Down
2 changes: 1 addition & 1 deletion ext/opcache/config.w32
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ if (PHP_OPCACHE != "no") {
}
}

ADD_FLAG('CFLAGS_OPCACHE', "/I " + configure_module_dirname);
ADD_FLAG('CFLAGS_OPCACHE', "/I " + configure_module_dirname + " /D ZEND_EXT_EXPORTS");

}

Loading