Skip to content

Conversation

nielsdos
Copy link
Member

A cache slot can be hit with different DOM object types, so we should check if we're still handling the same type.

@nielsdos nielsdos linked an issue Aug 31, 2024 that may be closed by this pull request
A cache slot can be hit with different DOM object types, so we should
check if we're still handling the same type.
Copy link
Member

@SakiTakamachi SakiTakamachi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@nielsdos nielsdos merged commit 82c504f into php:master Aug 31, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Polymorphic cache slot issue in DOM
2 participants