Fix ubsan build on freebsd regarding float. #15935
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iluuu1994
approved these changes
Sep 24, 2024
Zend/zend_operators.h
Outdated
| @@ -27,7 +27,19 @@ | |||
| #include <stddef.h> | |||
|
|
|||
| #ifdef HAVE_IEEEFP_H | |||
| #include <ieeefp.h> | |||
| /// On FreeBSD with ubsan/clang we get the following: | |||
There was a problem hiding this comment.
Nit: We're pretty much never using /// comments.
due to the system header machine/ieeefp.h proceeding to a bitshift operation.
devnexen
force-pushed
the
fix_fbsd_ubsan
branch
from
97d24f6 to
65c0c68
Compare
gcc on freebsd does not work that well anyway, clang is the main compiler. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
due to the system header machine/ieeefp.h proceeding to a bitshift operation.