Skip to content

Conversation

devnexen
Copy link
Member

No description provided.

@devnexen devnexen requested a review from bukka as a code owner September 17, 2024 18:45
@devnexen devnexen marked this pull request as draft September 17, 2024 18:45
@devnexen devnexen linked an issue Sep 17, 2024 that may be closed by this pull request
@devnexen devnexen marked this pull request as ready for review September 17, 2024 19:58
Copy link
Member

@cmb69 cmb69 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for tackling this!

Copy link
Member

@cmb69 cmb69 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, except for the nits regarding the test case.

@cmb69 cmb69 removed the ABI break label Sep 30, 2024
@devnexen devnexen closed this in 332b067 Sep 30, 2024
jorgsowa pushed a commit to jorgsowa/php-src that referenced this pull request Oct 1, 2024
jorgsowa pushed a commit to jorgsowa/php-src that referenced this pull request Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

php_network.h integer overflow
2 participants