Skip to content

Fix GH-16039: Segmentation fault (access null pointer) in ext/dom/parentnode/tree.c #16056

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Fix GH-16039: Segmentation fault (access null pointer) in ext/dom/parentnode/tree.c #16056

wants to merge 1 commit into from

Conversation

nielsdos
Copy link
Member

dom_object_get_node() can fail if we don't have a user object associated.

This is gonna be a fun one to merge upwards...

@nielsdos nielsdos linked an issue Sep 25, 2024 that may be closed by this pull request
Segmentation fault (access null pointer) in ext/dom/parentnode/tree.c #16039
Closed
Girgias
Girgias approved these changes Sep 25, 2024
View reviewed changes
Copy link
Member

@Girgias Girgias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one question about if we even want to let this not throw an exception

@nielsdos
Fix phpGH-16039: Segmentation fault (access null pointer) in ext/dom/…
555d240 
…parentnode/tree.c

dom_object_get_node() can fail if we don't have a user object
associated.

Closes phpGH-16056.
Girgias
Girgias approved these changes Sep 25, 2024
View reviewed changes
Copy link
Member

@Girgias Girgias left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if CI is green (ignore Cirrus as we are at the end of the month and no more credit)

@nielsdos nielsdos closed this in 043b9e1 Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Girgias Girgias Girgias approved these changes

Assignees
No one assigned
Labels
Extension: dom
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Segmentation fault (access null pointer) in ext/dom/parentnode/tree.c
2 participants
@nielsdos @Girgias