Fix #70831: Compile fails on system with 160 CPUs #1615
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the following build issue on 160-CPU POWER8 machines ext/tokenizer/tokenizer_data.c:28:34: fatal error: zend_language_parser.h: No such file or directory #include <zend_language_parser.h> It is fixed by introducing an explicit dependency on the header file. Signed-off-by: Daniel Axtens <dja@axtens.net>
|
Obviously this is now too late for PHP7.0.0, but would it be possible to get it into the next point release? It's a blocker for compiling reliably on POWER. |
|
Pinging @weltling as PHP7 RM. |
|
Comment on behalf of ab at php.net: Merged into 7.0, thanks! |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the following build issue on 160-CPU POWER8 machines
ext/tokenizer/tokenizer_data.c:28:34: fatal error: zend_language_parser.h: No such file or directory #include <zend_language_parser.h>It is fixed by introducing an explicit dependency on the header file.
Signed-off-by: Daniel Axtens dja@axtens.net