Bug #70861: Fix binding of empty string resource as a parameter. #1619
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: https://bugs.php.net/bug.php?id=70861
The original fix for https://bugs.php.net/bug.php?id=70861 unfortunately did fix the crash, but not the issue.
The problem is given a PG SQL PDO stmt $stmt when doing:
That then php_stream_copy_to_mem() returns NULL, but if we don't bind the placeholder than the query fails.
The attached patch uses an empty ZSTR to remove the problem, which probably makes sense that an empty resource is mapped to an empty string instead of NULL.
There might be a better fix available, but this fixes the test for me.