Declare zend_call_stack_size_error() as ZEND_API #16204
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is necessary at least on Windows to be able to actually call the function from a different module (in this case php8phpdbg.dll could not be build).
arnaud-lb
approved these changes
Oct 3, 2024
|
No ABI break; just an addition to fix Windows builds. |
nielsdos
added a commit
to nielsdos/php-src
that referenced
this pull request
Oct 4, 2024
With phpGH-16204 merged, we can use the standard error message for the recently-merged phpGH-16159.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is necessary at least on Windows to be able to actually call the function from a different module (in this case php8phpdbg.dll could not be build).
The
zend_never_inlinemay no longer be necessary (or have any effect).cc @arnaud-lb