Skip to content

Fix GH-16354 convert GMP to number failure. #16368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Fix GH-16354 convert GMP to number failure. #16368

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
52fe9b0
Fix GH-16354 convert GMP to number failure.
devnexen Oct 11, 2024
64c6a66
add/update test
devnexen Oct 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions ext/gmp/gmp.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -619,6 +619,15 @@ static zend_result convert_to_gmp(mpz_t gmpnumber, zval *val, zend_long base, ui
case IS_STRING: {
return convert_zstr_to_gmp(gmpnumber, Z_STR_P(val), base, arg_pos);
}
case IS_NULL: {
/**
* zend_parse_arg_long_slow support nullable argument but expects it
* to be the 2nd, and onward, argument or non null but at any place.
**/
zend_type_error(
"Number must be of type GMP|string|int, null given");
return FAILURE;
}
default: {
zend_long lval;
if (!zend_parse_arg_long_slow(val, &lval, arg_pos)) {
Expand Down
12 changes: 12 additions & 0 deletions ext/gmp/tests/gh16368.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
--TEST--
Bug GH-16368: gmp_init on first argument as null.
--EXTENSIONS--
gmp
--FILE--
<?php
gmp_init($inexistent);
?>
--EXPECTF--
Warning: Undefined variable $inexistent in %s on line %d

Deprecated: gmp_init(): Passing null to parameter #1 ($num) of type string|int is deprecated in %s on line %d
2 changes: 1 addition & 1 deletion ext/gmp/tests/gmp_strict_types.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,5 +53,5 @@ object(GMP)#2 (1) {
gmp_abs(): Argument #1 ($num) must be of type GMP|string|int, float given
gmp_abs(): Argument #1 ($num) must be of type GMP|string|int, bool given
gmp_abs(): Argument #1 ($num) must be of type GMP|string|int, bool given
gmp_abs(): Argument #1 ($num) must be of type GMP|string|int, null given
Number must be of type GMP|string|int, null given
gmp_abs(): Argument #1 ($num) must be of type GMP|string|int, array given
Loading