New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement FR #55651: (Option to ignore the returned FTP PASV address) #1668

Closed
wants to merge 1 commit into
base: PHP-5.6
from

Conversation

5 participants
@kaplanlior
Contributor

kaplanlior commented Dec 10, 2015

This patch waits 4 years for review, while a lot of people complain (e.g. number of votes).

More info also at http://www.elitehosts.com/blog/php-ftp-passive-ftp-server-behind-nat-nightmare/

@kaplanlior kaplanlior changed the title from Implement FR #55651: (Option to ignore the retured FTP PASV address) to Implement FR #55651: (Option to ignore the returned FTP PASV address) Dec 10, 2015

@weltling

This comment has been minimized.

Show comment
Hide comment
@weltling

weltling Dec 14, 2015

Contributor

@kaplanlior i'm fine with the patch, do you plan to port it for 7.0? But i've probably no conditions to test it. So if good and tested, please pull in.

Thanks.

Contributor

weltling commented Dec 14, 2015

@kaplanlior i'm fine with the patch, do you plan to port it for 7.0? But i've probably no conditions to test it. So if good and tested, please pull in.

Thanks.

@kaplanlior

This comment has been minimized.

Show comment
Hide comment
@kaplanlior

kaplanlior Dec 14, 2015

Contributor

I attached the 7.0 port to the bug report: https://bugs.php.net/patch-display.php?bug_id=55651&patch=ftp_usepasvaddress_php70.patch&revision=latest

And yes, testing is tricky.

Contributor

kaplanlior commented Dec 14, 2015

I attached the 7.0 port to the bug report: https://bugs.php.net/patch-display.php?bug_id=55651&patch=ftp_usepasvaddress_php70.patch&revision=latest

And yes, testing is tricky.

@laruence laruence added the Bugfix label Dec 14, 2015

@php-pulls

This comment has been minimized.

Show comment
Hide comment
@php-pulls

php-pulls Dec 15, 2015

Comment on behalf of kaplan at php.net:

Merged as 90a26a4

php-pulls commented Dec 15, 2015

Comment on behalf of kaplan at php.net:

Merged as 90a26a4

@php-pulls php-pulls closed this Dec 15, 2015

salathe pushed a commit to salathe/phpdoc-en that referenced this pull request Jan 10, 2018

Pasindu De Silva
ftp_set_option missed option FTP_USEPASVADDRESS
added in: php/php-src#1668

-- 
Provided by anonymous 86357 (spee.jeroen@gmail.com)

git-svn-id: https://svn.php.net/repository/phpdoc/en/trunk@343809 c90b9560-bf6c-de11-be94-00142212c4b1

LawnGnome pushed a commit to LawnGnome/phpdoc-en that referenced this pull request Jan 10, 2018

pasindu
ftp_set_option missed option FTP_USEPASVADDRESS
added in: php/php-src#1668

-- 
Provided by anonymous 86357 (spee.jeroen@gmail.com)

git-svn-id: https://svn.php.net/repository/phpdoc/en/trunk@343809 c90b9560-bf6c-de11-be94-00142212c4b1

svn2github pushed a commit to svn2github/phpdoc_en that referenced this pull request Jan 10, 2018

pasindu
ftp_set_option missed option FTP_USEPASVADDRESS
added in: php/php-src#1668

-- 
Provided by anonymous 86357 (spee.jeroen@gmail.com)

git-svn-id: http://svn.php.net/repository/phpdoc/en@343809 c90b9560-bf6c-de11-be94-00142212c4b1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment