Fix 2 segfaults in the range() function #1677
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Both segfaults occur due to accuracy lost when representing 64bit longs as doubles. The segfaults can be replicated with: range(PHP_INT_MIN + 513, PHP_INT_MIN); // Seg fault on line 2236 range(PHP_INT_MAX - 512, PHP_INT_MAX); // Seg fault on line 2249
tpunt
force-pushed
the
fix-segfaults-in-range-function
branch
from
4bc9886 to
36bc2fc
Compare
This caused a few tests to fail because a different error message was being output
| || (high == ZEND_LONG_MIN && low > -2) /* overflow check */ | ||
| || __calc_size > HT_MAX_SIZE /* the array size is too big */ | ||
| ) { | ||
| php_error_docref(NULL, E_WARNING, "The supplied range exceeds the maximum array size: start=%ld end=%ld", high, low); |
There was a problem hiding this comment.
An appropriate sprintf format should be used for zend_long, please see UPGRADING INTERNALS.
tpunt
force-pushed
the
fix-segfaults-in-range-function
branch
3 times, most recently
from
ed1f449 to
5433534
Compare
tpunt
force-pushed
the
fix-segfaults-in-range-function
branch
3 times, most recently
from
73f14ad to
8e4dd2f
Compare
tpunt
force-pushed
the
fix-segfaults-in-range-function
branch
from
8e4dd2f to
62f379e
Compare
By using the calculated array size to determine the number of loop iterations, we no longer need to perform overflow checks in the loops
|
Dups with #1690 ? |
|
Per PR description these 2 PRs fix at least different bug-ids |
|
@jpauli Nope, the segfaults are in different places. |
|
Roger |
Closed
|
Superseded by PR #1695. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both segfaults occur due to accuracy lost when representing 64bit longs as
doubles.
The segfaults can be replicated with:
This fixes Bug #71132