Fix GH-16902: Set of opcache tests fail zts+aarch64 (8.4+) #16924
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Accompanying IR PR: dstogov/ir#95
nielsdos
commented
Nov 24, 2024
| "add %0, %0, :tlsdesc_lo12:_tsrm_ls_cache\n" | ||
| : "=r" (where)); | ||
| /* See https://github.com/ARM-software/abi-aa/blob/2a70c42d62e9c3eb5887fa50b71257f20daca6f9/aaelf64/aaelf64.rst */ | ||
| size_t *tlsdesc = where[1]; |
There was a problem hiding this comment.
This is the same as for FreeBSD a couple of lines up, defined by the ABI.
Comment on lines
+3247
to
+3248
| tsrm_tls_offset = tlsdesc[1]; | ||
| tsrm_tls_index = tlsdesc[0] * 8; |
There was a problem hiding this comment.
These computations for offset and index are the same as on x86-64 MUSL.
dstogov
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Accompanying IR PR: dstogov/ir#95
NOTE: X64 CI job failure is unrelated
Confirmed working by Alpine Linux team member #16902 (comment)