Skip to content

ext/pdo: Drop redundant mode check, and fix the first check #17302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 1, 2025
Merged

ext/pdo: Drop redundant mode check, and fix the first check #17302

merged 1 commit into from
Jan 1, 2025

Conversation

Girgias
Copy link
Member

@Girgias Girgias commented Dec 30, 2024

No description provided.

kamil-tekiela
kamil-tekiela approved these changes Dec 30, 2024
View reviewed changes
Copy link
Member

@kamil-tekiela kamil-tekiela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like when Antony added that check 19 years ago, he didn't see that there already was one at the end of the switch.

@Girgias Girgias merged commit 1969955 into php:master Jan 1, 2025
10 checks passed
@Girgias Girgias deleted the pdo-redudant-mode-check branch January 1, 2025 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kamil-tekiela kamil-tekiela kamil-tekiela approved these changes

@SakiTakamachi SakiTakamachi Awaiting requested review from SakiTakamachi SakiTakamachi is a code owner

Assignees
No one assigned
Labels
Extension: pdo (core)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Girgias @kamil-tekiela