Added mandatory Date: header to built-in webserver - bug #71276 #1733
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@seeschloss Just something minor, can it go above the |
seeschloss
force-pushed
the
php-bug-71276
branch
from
3d1ad51 to
7f35afb
Compare
seeschloss
force-pushed
the
php-bug-71276
branch
from
7f35afb to
d0744c9
Compare
|
Yeah I agree with you, I prefer it too. I also fixed two tests which I had missed somehow. |
| @@ -348,6 +349,13 @@ static void append_essential_headers(smart_str* buffer, php_cli_server_client *c | |||
| smart_str_appendl_ex(buffer, "\r\n", 2, persistent); | |||
| } | |||
| } | |||
| time_t t; | |||
There was a problem hiding this comment.
The declaration should got to the start of the block.
|
Merged with f33c7b3 and some correction. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As explained here: https://bugs.php.net/bug.php?id=71276
The Date: header is mandatory in a HTTP response.
This pull-requests adds it and fixes the various tests that were impacted as well.
Also, this doesn't touch the Host: header but this one should be removed in the future, as well.