Add enchant_dict_remove_from_session() #17393
Conversation
| $dicts = enchant_broker_list_dicts($broker); | ||
| $newWord = 'myImaginaryWord'; | ||
|
|
||
| $requestDict = enchant_broker_request_dict($broker, $dicts[0]['lang_tag']); |
There was a problem hiding this comment.
Mind adding a test which includes a null byte in the string?
There was a problem hiding this comment.
Oh you're gonna love this.
Turns out that enchant crashes when you have a null byte in a string, for all the existing methods too...
So the fact that nulls aren't prevented is a bug since the introduction of the enchant extension.
Try it yourself!
<?php
$broker = enchant_broker_init();
$dicts = enchant_broker_list_dicts($broker);
$requestDict = enchant_broker_request_dict($broker, $dicts[0]['lang_tag']);
var_dump(enchant_dict_check($requestDict, "foo\0bar"));libenchant-CRITICAL **: 19:54:21.646: string_substring: assertion '(offset + len) <= string_length' failed
And then a segfault
I guess I'll make a PR for lower branches to change the "s" to "p".
There was a problem hiding this comment.
Lovely, I wonder how many bugs could be found by fuzzing extension functions with strings that contain null bytes.
@YuanchengJiang you might want to try this in your fuzzer.
There was a problem hiding this comment.
I rebased this and added a commit to properly handle the null bytes.
Will squash ofc on merge.
No description provided.