Skip to content

ext/pdo: Add a test for PDO::FETCH_FUNC with a return by-ref callback #17425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 10, 2025
Merged

ext/pdo: Add a test for PDO::FETCH_FUNC with a return by-ref callback #17425

merged 1 commit into from
Jan 10, 2025

Conversation

Girgias
Copy link
Member

@Girgias Girgias commented Jan 9, 2025

@nielsdos seems to behave as expected.

@Girgias Girgias requested a review from SakiTakamachi as a code owner January 9, 2025 22:15
nielsdos
nielsdos approved these changes Jan 10, 2025
View reviewed changes
Copy link
Member

@nielsdos nielsdos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat

@Girgias Girgias merged commit 11937b3 into php:master Jan 10, 2025
10 checks passed
@Girgias Girgias deleted the pdo-fetch-function-return-by-ref branch January 10, 2025 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nielsdos nielsdos nielsdos approved these changes

@SakiTakamachi SakiTakamachi Awaiting requested review from SakiTakamachi SakiTakamachi is a code owner

Assignees
No one assigned
Labels
Extension: pdo (core)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Girgias @nielsdos