Fix GH-12856: ReflectionClass::getStaticPropertyValue() returns UNDEF zval for uninitialized typed properties #17590
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…DEF zval for uninitialized typed properties
nielsdos
commented
Jan 26, 2025
ext/reflection/php_reflection.c
Outdated
| "Property %s::$%s does not exist", ZSTR_VAL(ce->name), ZSTR_VAL(name)); | ||
| if (prop) { | ||
| zend_throw_exception_ex(reflection_exception_ptr, 0, | ||
| "Property %s::$%s is not initialized and no default was provided", ZSTR_VAL(ce->name), ZSTR_VAL(name)); |
There was a problem hiding this comment.
Perhaps this should say "Typed property (...)" to emphasize that this is for typed props?
There was a problem hiding this comment.
May we not just use the existing message that is already used when uninitialized accessing typed properties?
Typed static property C::$prop must not be accessed before initialization
There was a problem hiding this comment.
Maybe, and then just as an Error rather than a ReflectionException or not?
There was a problem hiding this comment.
I've changed it to the standard wording. Although I like the custom message that I had put (as it indicates why the exception is thrown more precisely), I see the appeal of using the standard wording.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This issue has been open for a while, and it's easy to fix, we just have to agree what is right.
As per my comment, I sent an email to internals to see what people think: https://externals.io/message/126224