Fix memory leak in phpdbg calling registered function #17635
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The length of the string should be set to the truncated length (that was used to duplicate the input anyway).
Girgias
reviewed
Jan 30, 2025
nielsdos
force-pushed
the
phpdbg-leaks-again
branch
from
b96fee2 to
c2389c1
Compare
Girgias
approved these changes
Jan 30, 2025
charmitro
pushed a commit
to wasix-org/php
that referenced
this pull request
Mar 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The named arguments array is never cleaned up, so a trivial memory leak.
I first had to partially fix GH-17387 though to prevent crashing...
This was detected using an experimental static analyser I'm developing.