Skip to content

Fixed bug #53432 #1764

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Fixed bug #53432 #1764

wants to merge 1 commit into from

Conversation

nikic
Copy link
Member

@nikic nikic commented Feb 14, 2016

Treat empty strings the same as any other string when string offset assignment is used.

Refs http://php.net/53432

@hikari-no-yume
Copy link
Contributor

Was this an unintended consequence of treating falsy values as empty arrays?

@flaupretre
Copy link
Contributor

Wouldn't it be the occasion to disable auto conversion of bool types too ?

IMO, IS_NULL may remain auto-converted, mostly for BC reasons, but true/false should raise "Cannot use a scalar value as an array".

The problem is that this probably cannot be considered as a bugfix...

@hikari-no-yume
Copy link
Contributor

It might need an RFC :/

@nikic
Copy link
Member Author

nikic commented Jun 4, 2016

Merged via 945a831.

@nikic nikic closed this Jun 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants