Bug #71667: have pdo_dblib emulate how mssql extension names "computed" columns, plug memory leak (PHP-5.6) #1775
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Full notes are in the bug report I created:
https://bugs.php.net/bug.php?id=71667
The efree() calls could be removed from dblib_stmt.c because free_statement(), which is part of the pdo extension, will do this cleanup before the functions in dblib_stmt.c get called.
I realize that README.GIT-RULES says PRs should be done against PHP-5.6, but that branch is missing changes that my changes are built on top of. I'm happy to update this PR if anyone has guidance there. I'm going to look at master separately and submit another bug/PR if needed.