Request #69112: PDO DBlib: handle types the same way as mssql extension (PHP-5.6) #1784
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Since this has merge conflicts, and targets a security fix only branch, and since another patch would be required for a supported branch anyway, I'm closing this PR. Please take this action as encouragement to open a clean PR targeting an appropriate branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces #1122.
This patch changes the extension to return column data as zvals instead of char arrays. If the stringify attribute is set to true, data will be returned as strings (existing behavior); if false, data will be handled the same way as the mssql extension.
I verified the test output using the existing code to make sure my updates didn't introduce any regressions.
I'd recommend getting this into PHP-5.6 because it'll smooth out the mssql -> pdo_dblib migration path, as described in #1780.