Fix GH-18212: fseek with SEEK_CUR and negative offset crash on debug #18224
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bukka
approved these changes
Apr 2, 2025
ext/standard/tests/file/gh18212.phpt
Outdated
| @@ -0,0 +1,13 @@ | |||
| --TEST-- | |||
| GH-18212 fseek with SEEK_CUR and negative offset leads to negative file stream position. | |||
There was a problem hiding this comment.
NIT
Suggested change
| GH-18212 fseek with SEEK_CUR and negative offset leads to negative file stream position. | |
| GH-18212: fseek with SEEK_CUR and negative offset leads to negative file stream position. |
Triggers the assertion as with SEEK_CUR the stream position is set to a negative value so we force the failure without affecting its position instead. close phpGH-18224
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Triggers the assertion as with SEEK_CUR the stream position is set to a negative value so we force the failure without affecting its position instead.