replace match statements with if statements in gdb debug script #18226
+120
−130
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @lcarilla. You also need to run the scripts/gdb/debug_gdb_scripts_gen.php script, I believe. |
… works with lower GDB versions
lcarilla
force-pushed
the
gdb-scripts-compatibility
branch
from
5bbd23c to
8581c69
Compare
|
Had the same issue |
bukka
approved these changes
Apr 2, 2025
|
Thank you @lcarilla! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
so it works with lower GDB versions, had a lot of pain with this.
match is a really new python feature, the most recent LTS ubuntu version (24.04) ships gdb 15.x which comes with python3.8 and therefore doesnt work with this script. lets make it more available to people developing without the latest gdb/python version