Transparently introduce type-specialized opcode handlers. #1824
Conversation
This affects only PHP VM, and doesn't change anything else.
| zval *var_ptr; | ||
|
|
||
| var_ptr = GET_OP1_ZVAL_PTR_PTR_UNDEF(BP_VAR_RW); | ||
| ZVAL_COPY_VALUE(EX_VAR(opline->result.var), var_ptr); |
There was a problem hiding this comment.
Since var_ptr must be IS_LONG here, so use ZVAL_LONG(EX_VAR(opline->result.var), Z_LVAL_P(var_ptr)) maybe faster.
|
Honestly, I preferred the old version with a single if … Currently we have anyway a short quick branching in the ZEND_ADD opcode. This gets pretty much redundant code, also adding the risk of forgetting to update an opcode handler when changing something. |
|
hmm..... I merge this patch wrongly when I was pushing a bug fix.. how should I reopen this ? |
|
The old version required separate opcode for each new specialization, and the whole number of opcodes is limited by 256. On Wed, Mar 16, 2016 at 10:29 AM -0700, "Bob Weinand" <notifications@github.commailto:notifications@github.com> wrote: Honestly, I preferred the old version with a single if ... Currently we have anyway a short quick branching in the ZEND_ADD opcode. This gets pretty much redundant code, also adding the risk of forgetting to update an opcode handler when changing something. You are receiving this because you authored the thread. |
This affects only PHP VM and optimizer, and doesn't change anything else outside.