ext/gd: array supplied to user optimisations. #18366
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
explictly allocate packed arrays when it applies.
devnexen
force-pushed
the
gd_packed_array
branch
from
938d73e to
93e4bf5
Compare
nielsdos
reviewed
Apr 20, 2025
ext/gd/gd.c
Outdated
| array_init(return_value); | ||
| add_next_index_long(return_value, gdImageResolutionX(im)); | ||
| add_next_index_long(return_value, gdImageResolutionY(im)); | ||
| array_init_size(return_value, 2); |
There was a problem hiding this comment.
There's zend_new_pair for an optimized version of returning a packed array of 2 elements
nielsdos
approved these changes
Apr 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
explictly allocate packed arrays when it applies.