ext/sqlite3: querySingle amd fetchArray methods optimisations. #18385
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nielsdos
requested changes
Apr 21, 2025
ext/sqlite3/sqlite3.c
Outdated
| @@ -1948,6 +1949,7 @@ PHP_METHOD(SQLite3Result, fetchArray) | |||
| } | |||
|
|
|||
| array_init(return_value); | |||
| zend_hash_real_init_packed(Z_ARRVAL_P(return_value)); | |||
There was a problem hiding this comment.
This should be removed, the loop below can also add associative keys in some cases
pre-allocated size for the former and packed array.
devnexen
force-pushed
the
sqlite3_array_optim
branch
from
c3c2a7d to
cbc2b8b
Compare
nielsdos
approved these changes
Apr 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pre-allocated size for the former and packed array.