Make phpize set a proper build type (windows) (bug #71911) #1841
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The build type of an extension must correspond to that of PHP. Phpize set a proper one automatically from PHP_DEBUG.
y-uti
changed the title
| @@ -229,7 +229,7 @@ C.Write(file_get_contents(PHP_DIR + "/script/config.phpize.js")); | |||
| // Pull in code for the base detection | |||
| modules = file_get_contents(PHP_DIR + "/script/config.w32.phpize.in"); | |||
|
|
|||
| C.WriteLine("ARG_ENABLE('debug', 'Compile with debugging symbols', \"no\");"); | |||
| C.WriteLine("ARG_ENABLE('debug', 'Compile with debugging symbols', PHP_DEBUG);"); | |||
There was a problem hiding this comment.
PHP_DEBUG is undefined at this place in configure.js
Thanks.
There was a problem hiding this comment.
I'm sorry, It has to be quoted.
I fixed it and sent a PR from another branch, please check #1848
Thanks,
|
PR #1848 merged. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The build type of an extension must correspond to that of PHP.
Phpize set a proper one automatically from PHP_DEBUG.