Reseed the RNG on the first call to openssl_random_pseudo_bytes #1843
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduces a simple function reinit_rng() that checks (new) module global `rng_inited_for_request` and calls RAND_poll() if it's not true. It's not the prettiest solution but the other solution seems to be to call RAND_poll() in RINIT which may occur a performance hit for each PHP request even if you're not using openssl functions. Other mentioned solutions depend on things like pthread_atfork() which seems out of scope for a PHP module.
| @@ -624,6 +630,14 @@ static STACK_OF(X509) * load_all_certs_from_file(char *certfile); | |||
| static X509_REQ * php_openssl_csr_from_zval(zval ** val, int makeresource, long * resourceval TSRMLS_DC); | |||
| static EVP_PKEY * php_openssl_generate_private_key(struct php_x509_request * req TSRMLS_DC); | |||
|
|
|||
| static void php_openssl_rand_seed() /* {{{ */ | |||
| { | |||
| if (!OPENSSL_G(rng_reseeded)) { | |||
There was a problem hiding this comment.
As I said in the bug report, the PHP_GINIT_FUNCTION is missing. In this case it means that you are checking uninitialized variable...
…ised values and to prevent from being fork-unsafe ourselves
…rt of random data
|
Comment on behalf of bukka at php.net: The PR #1857 addressing the issue in a different way has just been merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
php_openssl_rand_seed()that callsRAND_poll()ifOPENSSL_G(rng_reseeded)=0php_openssl_rand_seed()fromopenssl_random_pseudo_bytes()