Improve PDO entry in UPGRADING file #18446
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kamil-tekiela
force-pushed
the
Improve-UPGRADING-PDO
branch
from
ad15b87 to
69039fc
Compare
Girgias
approved these changes
Apr 27, 2025
There was a problem hiding this comment.
@Girgias, here's my attempt to clarify this. Though I still wonder why that is disallowed. It seems to me like a bit of an arbitrary restriction.
It adds a lot of unnecessary complexity for no good reason.
(and it probably also made the code slower)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Girgias, here's my attempt to clarify this. Though I still wonder why that is disallowed. It seems to me like a bit of an arbitrary restriction.