Skip to content

Conversation

iluuu1994
Copy link
Member

Caught by various tests in nightly. https://github.com/php/php-src/actions/runs/14767850964/job/41462688558

The use-of-uninitialized-value happens on this line:

zval_ptr_dtor_nogc(EX_VAR(throw_op->result.var));

It happens because because the ZEND_HANDLE_EXCEPTION handler assumes the result has already been initialized and potentially needs to be freed. To fix this, simply initialize the result to NULL, like we already do a few lines above.

@DanielEScherzer
Copy link
Member

I been waiting until this was no longer marked as a draft to review, but makes sense to me

@iluuu1994
Copy link
Member Author

@DanielEScherzer No worries. I sometimes don't do that because of unnecessary notifications to code owners.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants