Safe execution timeout handling. #1876
Conversation
|
Can't we possibly just reuse exception handling for this (throw an internal uncatchable exception)? And then check in the HANDLE_EXCEPTION opcode for whether it had been caused by a timeout? And we anyway check EG(exception) often enough... We then might need guards where altering the exceptions, but that should have a much lower impact than checking on every jump. Every loop iteration, every if statement is going to execute that check... |
|
I think, we can't safely throw exception from a signal handler. Because EG(exception) and EX(opline) may be changed inconsistently. From: Bob Weinand notifications@github.com Can't we possibly just reuse exception handling for this (throw an internal uncatchable exception)? And then check in the HANDLE_EXCEPTION opcode for whether it had been caused by a timeout? And we anyway check EG(exception) often enough... We then might need guards where altering the exceptions, but that should have a much lower impact than checking on every jump. Every loop iteration, every if statement is going to execute that check... You are receiving this because you authored the thread. |
|
That's why I'm saying, use guards. These guards always only are a non-conflicting mov instr, which should be minimal impact as EG(exception) is only supposed to be altered rarely. |
|
What about EX(opline), execute_data itself and OPLINE in CPU register? From: Bob Weinand notifications@github.com That's why I'm saying, use guards. These guards always only are a non-conflicting mov instr, which should be minimal impact as EG(exception) is only supposed to be altered rarely. You are receiving this because you authored the thread. |
* master: Fixed bug #72059 - Reference the bug id directly in NEWS Fix magic constants (__LINE__) with ?? for constant scalar exprs Add NEWS entry for ?? in constant scalar expressions allow null coalescing (??) on constant expressions Fix intl tests for ICU < 52 Fix ZTS builds by adding a missing TSRMLS_FETCH(). Fix bug #71737 Update NEWS Fix RECV opcode to handle all kinds of exceptions Fix RECV opcode to handle all kinds of exceptions
No description provided.