ext/intl: Use zval_get_tmp_string where possible #18966
Conversation
| zend_string *str_val, *tmp_str; | ||
|
|
||
| str_val = zval_get_string(val); | ||
| str_val = zval_get_tmp_string(val, &tmp_str); |
There was a problem hiding this comment.
Isn't there an exception check missing here if we have a non stringable object (or an error handler promoting the array to string warning) in val?
There was a problem hiding this comment.
Maybe, but does it matter? The exception will cause the VM to discard the result anyway. The only consequence is that we'll throw the exception a bit "late".
There was a problem hiding this comment.
I guess, I'm just used with us dealing with those sorts of things more proactively now, and I guess this can matter if there is a follow-up object that does some stuff with side-effects in __toString() ?
There was a problem hiding this comment.
If it's an internal object with a acst handler, it'll go through the cast handler, if that has side effects (which please god no) then it can cause problems.
If it's an internal or userland object, with a __toString method, then it won't call __toString if EG(exception) is already set. So in this case there can be no problems.
There was a problem hiding this comment.
Ah I forgot that the VM doesn't actual call follow-up methods in case of an Exception.
No description provided.