Skip to content

Use hasThis() where appropriate #18967

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 28, 2025
Merged

Use hasThis() where appropriate #18967

merged 1 commit into from
Jun 28, 2025

Conversation

nielsdos
Copy link
Member

This macro was introduced to solve false compilers warning about the getThis() condition not making sense for the address-taken part of the ternary.

@nielsdos
Use hasThis() where appropriate
c1b48d0 
This macro was introduced to solve false compilers warning about the getThis()
condition not making sense for the address-taken part of the ternary.
SakiTakamachi
SakiTakamachi approved these changes Jun 28, 2025
View reviewed changes
Copy link
Member

@SakiTakamachi SakiTakamachi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’ve confirmed that there are no other occurrences of the macro.

@nielsdos nielsdos merged commit 737db4a into php:master Jun 28, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devnexen devnexen devnexen approved these changes

@kamil-tekiela kamil-tekiela kamil-tekiela approved these changes

@SakiTakamachi SakiTakamachi SakiTakamachi approved these changes

@bukka bukka Awaiting requested review from bukka bukka is a code owner

Assignees
No one assigned
Labels
Extension: intl Extension: mysqli
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nielsdos @devnexen @kamil-tekiela @SakiTakamachi