fix bug #50989 add support LIBXML_NOXMLDECL for DOMDocument::saveXML() #1897
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| xmlSaveNoEmptyTags = saveempty; | ||
| } | ||
| if (!size) { | ||
| if(xmlSaveDoc(xscp, docp) < 0) { | ||
| RETURN_FALSE; |
There was a problem hiding this comment.
Leaks the buf (in all Return cases above)
cmb69
reviewed
Sep 26, 2016
| php_error_docref(NULL, E_WARNING, "Could not fetch buffer"); | ||
| RETURN_FALSE; | ||
| } | ||
| xmlSaveCtxtPtr xscp = xmlSaveToBuffer(buf, docp->encoding, options); |
There was a problem hiding this comment.
C89 doesn't allow mixing declarations and statements, so please move the declaration up to the start of the block.
|
@jhdxr fix conflicts please :) |
# Conflicts: # ext/dom/document.c
|
@krakjoe I have merged master and resolved the conflicts, however it seems the master branch is broken for now, so the ci fails. I'll check it later. |
|
@jhdxr bump, status please ? |
|
@krakjoe done :) |
|
Not able to apply:
|
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original implement use
xmlDocDumpFormatMemorywhich does not supportXML_SAVE_NO_DECL, so I replace them with xmlsave api.