Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bug72222 ReflectionClass::export() with array constants #1907

Conversation

2 participants
@nikita2206
Copy link
Contributor

commented May 16, 2016

@@ -456,7 +456,6 @@ static void _class_string(string *str, zend_class_entry *ce, zval *obj, char *in
zend_class_constant *c;

ZEND_HASH_FOREACH_STR_KEY_PTR(&ce->constants_table, key, c) {
zval_update_constant_ex(&c->value, c->ce);

This comment has been minimized.

Copy link
@nikic

nikic May 16, 2016

Member

Why did you remove this line?

This comment has been minimized.

Copy link
@nikita2206

nikita2206 May 16, 2016

Author Contributor

It was called twice - first here, and then in the _class_const_string. In my understanding there needs to be only one call to resolve the validity of this graph, right?

@nikita2206 nikita2206 force-pushed the nikita2206:fix-bug72222-reflection-array-const-export branch 2 times, most recently from b0c954f to a4d1fbc May 16, 2016

@nikic

This comment has been minimized.

Copy link
Member

commented Jul 13, 2016

Merged as eb190b4, thanks!

@nikic nikic closed this Jul 13, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.