Implement GH-18550: Implement getElementsByClassName() #19108
Merged
+364
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Girgias
reviewed
Jul 13, 2025
ext/dom/tests/modern/common/Element_getElementsByClassName_empty.phpt
Outdated
Show resolved
Hide resolved
ext/dom/tests/modern/common/Element_getElementsByClassName.phpt
Outdated
Show resolved
Hide resolved
nielsdos
commented
Jul 13, 2025
| dom_node_idx_pair start_point = dom_obj_map_get_start_point(map, nodep, index); | ||
| if (start_point.node) { | ||
| if (start_point.index > 0) { | ||
| /* Only start iteration at next point if we actually have an index to seek to. */ |
There was a problem hiding this comment.
FWIW, I did a correction here because we don't want to immediately skip the current index if the current index is already the one we need.
Girgias
approved these changes
Jul 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spec: https://dom.spec.whatwg.org/#ref-for-dom-element-getelementsbyclassname