Case test for curl_multi_info_read() function

[RyanNerd]

Test case for the curl_multi_info_read() function.
Tests required parameters only.

[staabm]

useless comment

[RyanNerd]

http://qa.php.net/write-test.php#comments

[staabm]

you should add a comment, when someone reading the code needs information about things not already obvious from the code.

writing something like

// this line will init curl
$c = curl_init();

does not provide more information.

[marcosptf]

dear[]s,

i already did this test since mar/13 on this PR ===> #1809
and the travis CI is running there!!!

@RyanNerd @staabm @rquadling @dsp @reeze

Merci

[RyanNerd]

http://gcov.php.net/viewer.php?version=PHP_HEAD&func=tested_functions

This indicates that this function as not having coverage. This is the QA
link I was told to use to determine where coverage is missing. Is this the
wrong URL?

On Wed, May 25, 2016 at 6:21 AM, marcosptf notifications@github.com wrote:

dear[]s,

i already did this this test since mar/13 on this PR ===> #1809
#1809
and the travis CI is running there!!!

@RyanNerd https://github.com/RyanNerd @staabm
https://github.com/staabm @rquadling https://github.com/rquadling @dsp
https://github.com/dsp @reeze https://github.com/reeze

Merci

—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#1922 (comment)

[marcosptf]

this is the official link, but need to see if don't have another PR open to there function, to don't duplicate test.

[RyanNerd]

Is there a case test I could help with that you can suggest, or should I go
through the official link looking for items that may or may not have
existing PRs?

On Wed, May 25, 2016 at 10:03 AM, marcosptf notifications@github.com
wrote:

this is the official link, but need to see if don't have another PR open
to there function, to don't duplicate test.

—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#1922 (comment)

[marcosptf]

@RyanNerd you are doing very well, just see what the Travis is boring and lets go with this test!

👍

[rquadling]

Any reason why I was included in #1922 (comment)? Maybe someone else should have been included.

[cmb69]

I'd prefer this test over PR #1809, mainly because it's testing against a local server and as such doesn't depend on an external website, and because the expectations are more meaningful.

The failing Travis check appears to be unrelated to this PR.

[marcosptf]

@cmb69 i wish Y! never die!

cross fingers

:-)

[RyanNerd]

Status on this PR?

[cmb69]

Status on this PR?

Two issues:

• the .phpt should be moved to ext/curl/tests (generally, each test should be put into the appropriate tests/ folder)
• the test should have a --SKIPIF-- section to prevent the test failing if the curl extension is not available (see how that's done in the other ext/curl/tests/*.phpt)

Otherwise the test is good to merge (I'd prefer to have it in PHP-7.0 also).

[smalyshev]

Please add SKIPIF here - look at other CURL tests as an example. Also, please move to ext/curl/tests/

[krakjoe]

PR #1809 was merged, so closing this one.