Skip to content

[RFC] Add support for dynamic variable names in function scope #1927

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

[RFC] Add support for dynamic variable names in function scope #1927

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4e1b9a3
Add support for dynamic strings as variables in scope of functions
haskellcamargo May 30, 2016
2ac4d88
Removed unused file
haskellcamargo May 30, 2016
ceeadb4
Add support to reference
haskellcamargo May 30, 2016
9ab5f29
Merge branch 'master' of https://github.com/haskellcamargo/php-src
haskellcamargo May 30, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions Zend/zend_language_parser.y
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1015,6 +1015,8 @@ lexical_var_list:
lexical_var:
T_VARIABLE { $$ = $1; }
| '&' T_VARIABLE { $$ = $2; $$->attr = 1; }
| '&' '$' '{' T_CONSTANT_ENCAPSED_STRING '}' { $$ = $4; $$->attr = 1; }
| '$' '{' T_CONSTANT_ENCAPSED_STRING '}' { $$ = $3; }
;

function_call:
Expand Down
14 changes: 14 additions & 0 deletions tests/func/012.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
--TEST--
Assert dynamic string variables can be imported to function scope with T_USE
--FILE--
<?php
${'+'} = function ($x, $y) { return $x + $y; };

$test_add = (function ($a, $b) use (${'+'}) {
return ${'+'}($a, $b);
})(10, 20);

echo $test_add;
?>
--EXPECT--
30
16 changes: 16 additions & 0 deletions tests/func/013.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
--TEST--
Assert dynamic reference string variables can be imported to function scope with T_USE
--FILE--
<?php
${'+'} = 10;

$test_ref = function () use (&${'+'}) {
${'+'} = 20;
};

$test_ref();

echo ${'+'};
?>
--EXPECT--
20