Add a 1-char fastpath to implode()
#19276
Open
+5
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think it's worth adding a 1 char fast path for
implode()
. A quick search on Github reveals the following stats:/implode\(\s*["'][^"']{1}["']\s*,\s*/ language:PHP
reveals 1.4 million occurrences/implode\(\s*["'][^"']{2,}["']\s*,\s*/ language:PHP
reveals 1.1 million occurrencesHere is the benchmark code:
And the results:
No change for multi char glue, but a nice improved performance for single char glue especially one big arrays.