Fix filtering of INI directives to respect leading whitespaces #19348
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
While analyzing the issue krakjoe/apcu#578 I noticed that the This happens, if the |
madmajestro
force-pushed
the
PHP-8.0-fix-deprecated-directive-regex-in-makfile
branch
from
122a889 to
de0f97b
Compare
|
I picked the wrong branch by mistake. Target branch is 8.3 now. |
Directives are now correctly filtered out if the line in the php.ini file begins with whitespace characters. Closes phpGH-19348
iluuu1994
force-pushed
the
PHP-8.0-fix-deprecated-directive-regex-in-makfile
branch
from
24ea1d2 to
9d29283
Compare
|
Thank you @madmajestro! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Directives are now correctly filtered out if the line in the php.ini file begins with whitespace characters.