Skip to content

fastcgi: fcgi_listen(), disallow SO_REUSEADDR socket option on windows. #19365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fastcgi: fcgi_listen(), disallow SO_REUSEADDR socket option on windows. #19365

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6998c1a
fastcgi: fcgi_listen(), disallow SO_REUSEADDR socket option on windows.
devnexen Aug 4, 2025
95d57c4
no need to bother with the var then
devnexen Aug 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions main/fastcgi.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -648,12 +648,8 @@ int fcgi_listen(const char *path, int backlog)
int listen_socket;
sa_t sa;
socklen_t sock_len;
#ifdef SO_REUSEADDR
# ifdef _WIN32
BOOL reuse = 1;
# else
#if !defined(_WIN32) && defined(SO_REUSEADDR)
int reuse = 1;
# endif
#endif

if ((s = strchr(path, ':'))) {
Expand Down Expand Up @@ -747,7 +743,13 @@ int fcgi_listen(const char *path, int backlog)

/* Create, bind socket and start listen on it */
if ((listen_socket = socket(sa.sa.sa_family, SOCK_STREAM, 0)) < 0 ||
#ifdef SO_REUSEADDR
#if !defined(_WIN32) && defined(SO_REUSEADDR)
/* SO_REUSEADDR on windows has a different behavior compared to unixes.
* It potentially allow a same address/port combination, even from an active connection (aka port hijacking).
* We trade the "fast port reuse on failure" ability though but performance ought to take a backseat on this matter.
* It might be tempting to use SO_EXCLUSIVEADDRINUSE, but it can significantly increase the amount of binding failures
* without real benefits .. but it is open for discussions.
*/
setsockopt(listen_socket, SOL_SOCKET, SO_REUSEADDR, (char*)&reuse, sizeof(reuse)) < 0 ||
#endif
bind(listen_socket, (struct sockaddr *) &sa, sock_len) < 0 ||
Expand Down