Throw ValueError when 1 is provided to the second argument of log()
#19370
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Girgias
reviewed
Aug 5, 2025
alexandre-daubois
force-pushed
the
log-base-1
branch
from
36f4140 to
755ddc6
Compare
alexandre-daubois
force-pushed
the
log-base-1
branch
from
755ddc6 to
8c5c508
Compare
alexandre-daubois
force-pushed
the
log-base-1
branch
from
8c5c508 to
964eff5
Compare
bukka
reviewed
Oct 1, 2025
Comment on lines
+670
to
+671
| if (base <= 0.0 || base == 1.0) { | ||
| zend_argument_value_error(2, "must not be 1 or less than or equal to 0"); |
There was a problem hiding this comment.
I would split it to two independent messages if we decide to do it.
|
I understand, I would also be fine throwing a deprecation for now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This helps with early error detection and explicit intent, instead of having a potential NaN propagating.