fix build warnings for Haiku. #19575
Closed
+8
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petk
reviewed
Aug 30, 2025
petk
reviewed
Aug 31, 2025
especially linker warning about php binary having an executable stack.
devnexen
force-pushed
the
haiku_build_warnings
branch
from
da202e9 to
6efe885
Compare
petk
approved these changes
Aug 31, 2025
|
I struggled with the branch choice but, ultimately, it is border line improvement as php still works despite this linker warning. |
|
no I just try from time to time to make sure it still build under exotic oses such as this one. No bug reports so far, especially as mentioned php works still without the change. |
|
|
So this just resolves a warning? |
|
A bit more than this, there is a security improvement implied. With this change, the linker marks this memory region as non executable which is better. |
DanielEScherzer
approved these changes
Sep 6, 2025
devnexen
added a commit
that referenced
this pull request
Sep 6, 2025
especially linker warning about php binary having an executable stack. cloe GH-19575
|
Merged with 2a96af7 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
especially linker warning about php binary having an executable stack.