Skip to content

Fix GH-19578: imagefilledellipse underflow on width argument. - #19579

Closed
devnexen wants to merge 2 commits into
php:PHP-8.3from
devnexen:gh19578
Closed

Fix GH-19578: imagefilledellipse underflow on width argument.#19579
devnexen wants to merge 2 commits into
php:PHP-8.3from
devnexen:gh19578

Conversation

@devnexen

Copy link
Copy Markdown
Member

No description provided.

@devnexen devnexen linked an issue Aug 25, 2025 that may be closed by this pull request
@devnexen
devnexen marked this pull request as ready for review August 25, 2025 06:35
@devnexen
devnexen requested a review from Girgias August 27, 2025 16:58
@devnexen

devnexen commented Sep 7, 2025

Copy link
Copy Markdown
Member Author

ping :)

@ndossche ndossche left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the same problem exist for the height argument?

Comment thread ext/gd/gd.c Outdated
RETURN_THROWS();
}

if (w < 0 || w > INT_MAX) {

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably can use ZEND_LONG_INT_OVFL to avoid compiler warnings for INT_MAX if zend_long==int.

@devnexen

devnexen commented Sep 7, 2025

Copy link
Copy Markdown
Member Author

Does the same problem exist for the height argument?

no

@devnexen devnexen closed this in 93865a4 Sep 7, 2025
adrian-enspired pushed a commit to adrian-enspired/php-src that referenced this pull request Aug 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

libgd runtime error: left shift of negative value

2 participants